Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library sidebar: don't allow deleting current history #11235

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 1, 2023

Even though the current's context-menu does not get the Delete action the actual deletion was still possible via hotkey.

fixes a regression introduced by #11172

Even though the current's context-menu does not get the Delete action
the actual deletion was still possible via hotkey.
@ronso0 ronso0 marked this pull request as ready for review February 1, 2023 01:15
@ronso0 ronso0 requested a review from daschuer February 1, 2023 01:16
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@daschuer daschuer merged commit 6f9b26f into mixxxdj:2.4 Feb 1, 2023
@ronso0 ronso0 deleted the history-dont-delete-current branch February 1, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants